Print unhandled exception to stdout depending on verbosity #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @cblp ! |
fumieval
reviewed
Feb 12, 2024
Web/Scotty/Action.hs
Outdated
| Handler $ \(E.SomeException e) -> do | ||
| when (verbose > 0) $ | ||
| liftIO $ | ||
| putStrLn $ "Caught and exception of " <> show (typeOf e) <> ": " <> show e |
There was a problem hiding this comment.
Is it intentional that it goes to stdout, not stderr?
There was a problem hiding this comment.
https://12factor.net/logs recommend stdout, but I'm not sure
There was a problem hiding this comment.
I don't have a strong opinion; I think stdout is fine too. By the way Caught and exception of looks like a typo
fumieval
approved these changes
Feb 15, 2024
ocramz
approved these changes
Feb 15, 2024
| @@ -1,6 +1,7 @@ | |||
| {-# LANGUAGE OverloadedStrings #-} | |||
| {-# LANGUAGE OverloadedStrings #-} | |||
| {-# LANGUAGE CPP #-} | |||
| {-# LANGUAGE NamedFieldPuns #-} | |||
There was a problem hiding this comment.
This allows to read record fields in the most natural way (in my taste):
-- line 179
someExceptionHandler Options{verbose} =
when (verbose > 0) ...
|
Hi @cblp , there are some small conflicts due to a PR I recently merged. Happy to merge your changes once they are fixed. Thanks again! |
ocramz
requested changes
Mar 9, 2024
ocramz
approved these changes
Mar 9, 2024
|
Thanks! |
lambdaTotoro
added a commit
to lambdaTotoro/scotty
that referenced
this pull request
Jun 26, 2024
Improved docs for `verbose` parameter of the `Options` type. This documents the changes from scotty-web#374 here as well.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.